(feat): (testing): Add extensible unpacking interface + controller tests #65
There are no files selected for viewing
|
everettraven marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Union source type | ||
| - op: add | ||
| path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/source/oneOf | ||
| value: | ||
| - required: | ||
| - image |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,15 +4,6 @@ kind: ClusterRole | |
| metadata: | ||
| name: manager-role | ||
| rules: | ||
|
Comment on lines
-7
to
-15
Member
There was a problem hiding this comment. Is the switch to pods instead of jobs only because rukpak provisioner uses an unpack pod instead of a job? This may have subtle but salient implications for catalogd due to the fact that there's product level differences between bundle images and catalog images. For eg, bundle images are generally publicly pull-able(at least has been advised to be that way, but that's totally up for debate possible in v1), however, catalog images are private/public, and private images will need pull secrets to be pulled, that's easily passable to a Job, vs a pod that needs additional configuration in the code. With that context, think more differences between bundle and catalog images showing up, and therefore the unpack pod needing to be more and more configured in code with for each difference.
Member
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Since we are pretty much copying the logic that rukpak uses internally and rukpak uses a Pod instead of Job, yes.
I'm not entirely sure I am following here. With FBC aren't catalog images just going to be images that contain a specific directory/file structure? IIUC this is exactly what a bundle is just on a smaller scale and the files are instead Kubernetes manifests. I understand that there are different views on what a catalog vs a bundle is, hence the creation of a @joelanford also makes good points - for reference, a Pod using a pull secret looks something like (Kubernetes docs on this): apiVersion: v1
kind: Pod
metadata:
name: private-reg
spec:
containers:
- name: private-reg-container
image: <your-private-image>
imagePullSecrets:
- name: regcred
Member
There was a problem hiding this comment. We've been bitten too many times for using pods directly instead of existing Kubernetes primitives in v0. When trying to use the pull secret example, I wasn't trying to suggest that you cannot do that with pods, but to the fact that the job/deployment controller does exactly that, pass on the pull secret to the pod it creates, but instead of letting the job/deployment controller do that we sign up for doing that ourselves, and then have to keep including tasks like this in our controller that we could have just delegated to the existing controllers. Eg tomorrow if there's a policy change that requires change in how pods are bootstrapped (think something similar to PSA), then there'll be three controllers incorporating those changes: the jobs controller, the deployment controller, and our controller. And then we have to worry about OCP releases/backports etc etc. Instead, using Kubernetes primitives mean we make minimal changes on our controller to incorporate policy changes, the same change that every other project will be making. But, sounds like we need to have this discussion in rukpak instead. Not resolving the conversation now so that we remember to capture this in an issue in rukpak by referencing this later. |
||
| - apiGroups: | ||
| - catalogd.operatorframework.io | ||
| resources: | ||
|
|
@@ -96,8 +87,12 @@ rules: | |
| resources: | ||
| - pods | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - get | ||
| - list | ||
| - patch | ||
| - update | ||
| - watch | ||
| - apiGroups: | ||
| - "" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,9 @@ | ||
| apiVersion: catalogd.operatorframework.io/v1beta1 | ||
| kind: Catalog | ||
| metadata: | ||
| name: operatorhubio | ||
| spec: | ||
| source: | ||
| type: image | ||
| image: | ||
| ref: quay.io/operatorhubio/catalog:latest |
Uh oh!
There was an error while loading. Please reload this page.