Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Conversation

@dmesser
Copy link
Collaborator

@dmesser dmesser commented Feb 7, 2019

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 15, 2019
@tkashem
Copy link
Contributor

tkashem commented Feb 15, 2019

/approve

apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
metadata:
description: etcd is a distributed key value store providing a reliable way to store data across a cluster of machines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this supposed to be moved to metadata.annotations

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
description: Service Catalog lets you provision cloud services directly from the comfort of native Kubernetes tooling. This project is in incubation to bring integration with service brokers to the Kubernetes ecosystem via the Open Service Broker API.
version: 0.1.34
keywords: ['catalog', 'service', 'svcat', 'osb', 'broker']
maturity: Seamless Upgrades
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svcat has been removed from this repo, so this change should be removed.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2019
@SamiSousa
Copy link
Contributor

@dmesser If maturity is based on the docs in operator-sdk, we should add a reference to it in our required fields doc.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 19, 2019
@dmesser
Copy link
Collaborator Author

dmesser commented Feb 19, 2019

rebased

apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
metadata:
metadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could the trailing whitespace be removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@SamiSousa
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@SamiSousa SamiSousa merged commit df9f838 into operator-framework:master Feb 19, 2019
SamiSousa pushed a commit to SamiSousa/community-operators that referenced this pull request Feb 21, 2019
- Reverts operator-framework#63 changes to values of spec.maturity in operator CSVs
- Move operator maturity level to metadata.annotations.capabilities

OLM's catalog-operator requires spec.maturity to have certain values
as outlined here:
    spec.maturity in body should be one of [planning pre-alpha
        alpha beta stable mature inactive deprecated]
This value isn't required to be set, but if the value isn't one of
the expected values above the installPlan fails.

/cc @dmesser @jeff-phillips-18
SamiSousa pushed a commit to SamiSousa/community-operators that referenced this pull request Feb 21, 2019
- Reverts operator-framework#63 changes to values of spec.maturity in operator CSVs
- Move operator maturity level to metadata.annotations.capabilities
- Update required-fields.md to include capabilities

OLM's catalog-operator requires spec.maturity to have certain values
as outlined here:
    spec.maturity in body should be one of [planning pre-alpha
        alpha beta stable mature inactive deprecated]
This value isn't required to be set, but if the value isn't one of
the expected values above the installPlan fails.

/cc @dmesser @jeff-phillips-18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants