This repository was archived by the owner on Jan 28, 2025. It is now read-only.
✨ Replace separator in NotSatisfiable error#158
Merged
everettraven merged 1 commit intooperator-framework:mainfrom Nov 13, 2023
Merged
✨ Replace separator in NotSatisfiable error#158everettraven merged 1 commit intooperator-framework:mainfrom
NotSatisfiable error#158everettraven merged 1 commit intooperator-framework:mainfrom
Conversation
Use new line instead of comma as a separator. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 11 11
Lines 495 495
=======================================
Hits 324 324
Misses 152 152
Partials 19 19 ☔ View full report in Codecov by Sentry. |
NotSatisfiable errorNotSatisfiable error
everettraven
approved these changes
Nov 13, 2023
everettraven
left a comment
There was a problem hiding this comment.
This will help a lot with readability!
ncdc
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new line instead of comma as a separator.
Example from operator-controller as yaml:
And as json:
{ "status": { "conditions": [ { "lastTransitionTime": "2023-11-13T13:43:28Z", "message": "constraints not satisfiable:\nargocd-operator package uniqueness permits at most 1 of operatorhubio-argocd-operator-argocd-operator.v0.6.0, operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator is mandatory\nrequired package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.6.0\nrequired package argocd-operator is mandatory", "observedGeneration": 2, "reason": "ResolutionFailed", "status": "False", "type": "Resolved" } ] } }Closes #150