⚠️ Remove DeppySolver wrapper and export internal solver instead

cmd/dimacs/cmd.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/spf13/cobra"
 
+	"github.com/operator-framework/deppy/pkg/deppy"
 	"github.com/operator-framework/deppy/pkg/deppy/solver"
 )
 
@@ -52,20 +53,29 @@ func solve(path string) error {
 	}
 
 	// build solver
-	so := solver.NewDeppySolver()
+	so, err := solver.New()
+	if err != nil {
+		return err
+	}
 
 	// get solution
 	vars, err := GenerateVariables(dimacs)
 	if err != nil {
 		return fmt.Errorf("error generating variables: %s", err)
 	}
-	solution, err := so.Solve(vars)
+	selection, err := so.Solve(vars)
 	if err != nil {
 		fmt.Printf("no solution found: %s\n", err)
 	} else {
+		selected := map[deppy.Identifier]struct{}{}
+		for _, variable := range selection {
+			selected[variable.Identifier()] = struct{}{}
+		}
+
 		fmt.Println("solution found:")
 		for _, variable := range vars {
-			fmt.Printf("%s = %t\n", variable.Identifier(), solution.IsSelected(variable.Identifier()))
+			_, ok := selected[variable.Identifier()]
+			fmt.Printf("%s = %t\n", variable.Identifier(), ok)
 		}
 	}
 

cmd/sudoku/cmd.go

@@ -22,19 +22,22 @@ func NewSudokuCommand() *cobra.Command {
 
 func solve() error {
 	// build solver
-	so := solver.NewDeppySolver()
+	so, err := solver.New()
+	if err != nil {
+		return err
+	}
 
 	// get solution
 	vars, err := GenerateVariables()
 	if err != nil {
 		return err
 	}
-	solution, err := so.Solve(vars)
+	selection, err := so.Solve(vars)
 	if err != nil {
 		fmt.Println("no solution found")
 	} else {
 		selected := map[deppy.Identifier]struct{}{}
-		for _, variable := range solution.SelectedVariables() {
+		for _, variable := range selection {
 			selected[variable.Identifier()] = struct{}{}
 		}
 		for row := 0; row < 9; row++ {

internal/solver/bench_test.go → pkg/deppy/solver/bench_test.go

@@ -20,7 +20,7 @@ var BenchmarkInput = func() []deppy.Variable {
 		nConflict   = 3
 	)
 
-	random := rand.New(rand.NewSource(seed))
+	random := rand.New(rand.NewSource(seed)) //nolint:gosec // G404: Use of weak random number generator (math/rand instead of crypto/rand) is ignored as this is not security-sensitive.
 
 	id := func(i int) deppy.Identifier {
 		return deppy.Identifier(strconv.Itoa(i))