Fix missing parameter in hook watch#235
Merged
everettraven merged 4 commits intooperator-framework:mainfrom Sep 12, 2023
Merged
Fix missing parameter in hook watch#235everettraven merged 4 commits intooperator-framework:mainfrom
everettraven merged 4 commits intooperator-framework:mainfrom
Conversation
juldrixx
changed the title
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
everettraven
requested changes
Sep 11, 2023
Contributor
There was a problem hiding this comment.
@juldrixx would you mind separating this into 2 PRs? One for the hook watch fix and one for the Go 1.21 bump? We tend to be more cautious when doing a Go bump as it can negatively impact projects that depend on this repository but might not be able to bump Go yet
Contributor
Author
Sure |
|
New changes are detected. LGTM label has been removed. |
juldrixx
changed the title
grokspawn
approved these changes
Sep 11, 2023
everettraven
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#216 updated the
dependentResourceWatcherstruct to add thecacheand thescheme, but did not initialize them even though they were passed on to creation.The
cacheis therefore empty and the code crashs on here.