Use package channel entries to lookup version#76
Merged
openshift-merge-robot merged 1 commit intooperator-framework:mainfrom Jan 18, 2023
Merged
Use package channel entries to lookup version#76openshift-merge-robot merged 1 commit intooperator-framework:mainfrom
openshift-merge-robot merged 1 commit intooperator-framework:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
joelanford
force-pushed
the
version-lookup
branch
from
d2d826e to
f11d922
Compare
openshift-merge-robot
added
the
needs-rebase
joelanford
force-pushed
the
version-lookup
branch
from
f11d922 to
389c946
Compare
openshift-merge-robot
removed
the
needs-rebase
joelanford
force-pushed
the
version-lookup
branch
5 times, most recently
from
d418d84 to
9a2a556
Compare
joelanford
force-pushed
the
version-lookup
branch
from
9a2a556 to
a348c5d
Compare
A listing of all channel entries was added in a recent version of the packagemanifests API. If the length of the list is 0, that means we're on an older version of the API, so we'll fall back to the previous behavior of just guessing a CSV name. With the updated packagemanifests API, we can iterate the list of entries and find the startingCSV, and error out if the specified version is not found. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
version-lookup
branch
from
a348c5d to
af5acc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A listing of all channel entries was added in a recent version of the packagemanifests API. If the length of the list is 0, that means we're on an older version of the API, so we'll fall back to the previous behavior of just guessing a CSV name.
With the updated packagemanifests API, we can iterate the list of entries and find the startingCSV, and error out if the specified version is not found.
Closes #2
Signed-off-by: Joe Lanford joe.lanford@gmail.com