Related to operator-framework/deppy#139 and possibly #329
In Reconcile we:
- Check to see if
Solve returned an error.
- This currently can happen if a variable source returns an error when getting variables.
- Notably, solve does NOT return an error for UNSAT. This error means "was not able to get variables or setup the solver"
- Look for the matching variable in the solution
We skip the step of checking if the solution was SAT or UNSAT. UNSAT currently manifests as an error looking up the bundle entity from the solution. This "works", but it means users don't see the UNSAT reason that comes from solution.Error()
We should check solution.Error(), and handle it accordingly.
Related to operator-framework/deppy#139 and possibly #329
In
Reconcilewe:Solvereturned an error.We skip the step of checking if the solution was SAT or UNSAT. UNSAT currently manifests as an error looking up the bundle entity from the solution. This "works", but it means users don't see the UNSAT reason that comes from
solution.Error()We should check
solution.Error(), and handle it accordingly.