📖[Docs] How-to: Channel-Based Automatic Updates#1220
Merged
joelanford merged 1 commit intooperator-framework:mainfrom Sep 7, 2024
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 77.55% 76.49% -1.07%
==========================================
Files 35 40 +5
Lines 1916 2340 +424
==========================================
+ Hits 1486 1790 +304
- Misses 296 393 +97
- Partials 134 157 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
everettraven
reviewed
Sep 5, 2024
OchiengEd
suggested changes
Sep 5, 2024
Contributor
OchiengEd
left a comment
OchiengEd
left a comment
There was a problem hiding this comment.
Looks good. I recommend slight rewording
| name: argocd-installer | ||
| ``` | ||
|
|
||
| Note that the `version` version range can also be set to further restrict the set of possible versions to upgrade to. |
Contributor
There was a problem hiding this comment.
This could be made clearer. Perhaps something like,
Note that the `version` field also accepts a version range to further restrict the set of possible operator versions to upgrade to.
Contributor
Author
There was a problem hiding this comment.
Nice! Thank you!!
I've updated it and tried to remove the preposition at the end? wdyt?
perdasilva
force-pushed
the
perdasilva/docs/howto-channel-based-upgd
branch
2 times, most recently
from
17e52f2 to
e928d0a
Compare
everettraven
reviewed
Sep 6, 2024
everettraven
reviewed
Sep 6, 2024
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
perdasilva/docs/howto-channel-based-upgd
branch
from
e928d0a to
2efe604
Compare
everettraven
approved these changes
Sep 6, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
joelanford
approved these changes
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1129
Reviewer Checklist