Skip to content

🌱 Bump catalogd to v0.27.0#1267

Closed
m1kola wants to merge 1 commit intooperator-framework:mainfrom
m1kola:catalogd_bump
Closed

🌱 Bump catalogd to v0.27.0#1267
m1kola wants to merge 1 commit intooperator-framework:mainfrom
m1kola:catalogd_bump

Conversation

@m1kola
Copy link
Copy Markdown
Member

@m1kola m1kola commented Sep 13, 2024

Description

Bump catalogd to v0.27.0 to include latest bug fixes & changes.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Bump catalogd to v0.27.0
8eda1ca 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 8eda1ca
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e4407cf6ad660008183a2e
😎 Deploy Preview https://deploy-preview-1267--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

m1kola
m1kola commented Sep 13, 2024
View reviewed changes
Comment thread test/e2e/e2e_suite_test.go
Type: catalogd.SourceTypeImage,
Image: &catalogd.ImageSource{
Ref: imageRef,
InsecureSkipTLSVerify: true,
Copy link
Copy Markdown
Member Author

@m1kola m1kola Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to deal with lack of InsecureSkipTLSVerify in E2Es somehow now.

Related: operator-framework/catalogd#369

Copy link
Copy Markdown
Contributor

@tmshort tmshort Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford's recent changes should've handled some of this... He added another CA to be trusted.

Copy link
Copy Markdown
Member Author

@m1kola m1kola Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did, but on operator-controller side. This is catalogd. operator-framework/catalogd#399 will help, but we still need to modify catalogd deployment on operator-catalog side to be able to use insecure TLS in E2E.

@tmshort tmshort mentioned this pull request Sep 13, 2024
Merged
@m1kola
Copy link
Copy Markdown
Member Author

m1kola commented Sep 16, 2024

We probably going to skip this version. We need another catalogd release and modify the deployment so that we can use insecure TLS.

@m1kola m1kola closed this Sep 16, 2024
@m1kola m1kola deleted the catalogd_bump branch November 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmshort tmshort tmshort left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola @tmshort