Add test for InstrumentedEnqueueRequestForObject#15
Merged
jmrodri merged 4 commits intooperator-framework:mainfrom Jul 30, 2020
Merged
Add test for InstrumentedEnqueueRequestForObject#15jmrodri merged 4 commits intooperator-framework:mainfrom
jmrodri merged 4 commits intooperator-framework:mainfrom
Conversation
Pull Request Test Coverage Report for Build 188099145
💛 - Coveralls |
92 tasks
Contributor
There was a problem hiding this comment.
Just a few nits:
- Could we add the suffix
_testwhich has special meaning for the Go compiler? So, it would bepackage handler_testinstead ofpackage handler
`
joelanford
reviewed
Jul 27, 2020
Member
Author
No, I wanted it in the same package as the code so I could also test the unexported methods. If we put it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test for the
InstrumentedEnqueueRequestForObjectto increase the code coverage.Before the test, handler was at 71.2%
After adding the test, coverage goes to 100%