Add CLI tool to build Operator Bundle image#1053
Add CLI tool to build Operator Bundle image#1053dinhxuanvu wants to merge 4 commits intooperator-framework:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8497b80 to
0c2b583
Compare
1. Add top level CLI command `operator-cli` 2. Add bundle command to generate annotations.yaml and Dockerfile 3. Add bundle command to build Bundle image * The build command will generate annotations.yaml and Dockerfile as well Signed-off-by: Vu Dinh <vdinh@redhat.com>
0c2b583 to
c419856
Compare
Signed-off-by: Vu Dinh <vdinh@redhat.com>
Signed-off-by: Vu Dinh <vdinh@redhat.com>
cea9957 to
54cdcc1
Compare
|
/retest |
awgreene
left a comment
There was a problem hiding this comment.
A few nits but it looks good to me.
50ae1d7 to
8fc2032
Compare
Signed-off-by: Vu Dinh <vdinh@redhat.com>
8fc2032 to
1ad51f4
Compare
|
@dinhxuanvu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
This is a great start @dinhxuanvu !
As discussed offline, we should move this into opm for now.
This PR scaffolds out Dockerfiles for building, which I think is useful.
But, I also think we can make this simpler for users. I think there should be a set of commands that use containerd or other oci libraries to build the image manifest directly.
Something like
opm bundle push --directory /test/0.0.1/ --tag quay.io/coreos/test-operator.v0.0.1:latestthat would build+push. The nice thing is that there is no dependency on docker or buildah for this. It's easy to build these images without tools like that because the images are well-defined and have no steps that require "running" and modifying the working layer and committing changes.
(this PR looks good, but I'm holding off lgtm until we finalize the enhancement - sorry!)
|
This PR is moved and replaced by another PR in operator-registry. Closed. |
operator-clias well
Signed-off-by: Vu Dinh vdinh@redhat.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs