resolver: remove legacy support for fallback parsing of CSVs#2291
Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom Jul 27, 2021
Merged
Conversation
When no APIs or properties are present on bundles, the resolver currently falls back to a legacy mode where that information is parsed from CSVs present in the index. This legacy fallback method causes the resolver to incorrectly identify multiple heads for a channel when: a) The index contains CSVs only on channel head bundles, and b) A package contains two channels, where one channel contains the head of the other channel and there is at least one other node between these channel head nodes in that channel. c) The bundles have no properties, provided APIs, or required APIs Conditions a) and b) are extremely prevalent, so this bug will often be encountered whenever c) itself is true. This commit removes support for the legacy CSV parsing fallback, which means that only first class fields in the GRPC API will be used during resolutions. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Member
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Member
|
/cherry-pick release-4.7 |
|
@timflannagan: #2291 failed to apply on top of branch "release-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This commit removes support for the legacy CSV parsing fallback, which
means that only first class fields in the GRPC API will be used during
resolutions.
Effectively reverts #1194
Motivation for the change:
When no APIs or properties are present on bundles, the resolver
currently falls back to a legacy mode where that information is parsed
from CSVs present in the index.
This legacy fallback method causes the resolver to incorrectly identify
multiple heads for a channel when:
a) The index contains CSVs only on channel head bundles, and
b) A package contains two channels, where one channel contains the head
of the other channel and there is at least one other non-channel-head node between
these channel head nodes in that channel.
c) The bundles have no properties, provided APIs, or required APIs
Conditions a) and b) are extremely prevalent, so this bug will often be
encountered whenever c) itself is true.
Reviewer Checklist
/doc