Add system-wide solver constraint injection#2360
Add system-wide solver constraint injection#2360njhale wants to merge 2 commits intooperator-framework:masterfrom
Conversation
Factor the content of main() into an exported function in a separate package so that it can be invoked externally.
Add an exported function that allows system-wide constraints -- i.e constraints used by all solvers -- to be injected.
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| func AddSystemConstraintProviders(providers ...ConstraintProvider) { | ||
| systemConstraintProviders.add(providers...) | ||
| } |
There was a problem hiding this comment.
Is this the extension point where callers can add custom providers (e.g. from an init function)?
It might be good to add an example in the PR summary of how a caller would add a custom provider.
njhale
changed the title
|
we decided to carry a downstream-only patch that no longer requires this injection point. |
2 participants
Description of the change:
main()function into an exported function in a non-main packageMotivation for the change:
Make it easier for platform-specific builds of OLM to perturb dependency resolution before "arbitrary runtime constraints" are available.