Makefile: Update the e2e target to use ginkgo#2367
Merged
timflannagan merged 1 commit intooperator-framework:masterfrom Oct 1, 2021
Merged
Makefile: Update the e2e target to use ginkgo#2367timflannagan merged 1 commit intooperator-framework:masterfrom
timflannagan merged 1 commit intooperator-framework:masterfrom
Conversation
timflannagan
force-pushed
the
update-make-e2e-target
branch
from
cf87cef to
8766239
Compare
njhale
reviewed
Sep 21, 2021
njhale
reviewed
Sep 21, 2021
timflannagan
force-pushed
the
update-make-e2e-target
branch
2 times, most recently
from
415ad4f to
ea5af1c
Compare
Member
|
/approve |
openshift-ci
Bot
added
the
approved
Update the root Makefile and update the `e2e` target to use the ginkgo executable instead of `go test ...` as logs produce when running the e2e suite aren't captured until after the process has completed. This leads to situations where failing tests aren't immediately communicated back and loss of logs entirely in the case where the process was manually teminated. Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
update-make-e2e-target
branch
from
ea5af1c to
729f57f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Force (squash) merging as the e2e-test failures aren't relevant to the changes in this PR - #2383 |
timflannagan
added a commit
to ankitathomas/operator-framework-olm
that referenced
this pull request
Oct 1, 2021
Update the root Makefile and extend the e2e/olm target to explicitly configure the ginkgo options that gets filtered to the staging/operator-lifecycle-manager e2e target that was introduced in [1]. [1] operator-framework/operator-lifecycle-manager#2367 Signed-off-by: timflannagan <timflannagan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the root Makefile and update the
e2etarget to use the ginkgoexecutable instead of
go test ...as logs produce when running the e2esuite aren't captured until after the process has completed. This leads
to situations where failing tests aren't immediately communicated back
and loss of logs entirely in the case where the process was manually
teminated.
Reviewer Checklist
/doc