fix(e2e): Use Eventually for installplan status fetch operation#2394
Closed
dinhxuanvu wants to merge 1 commit intooperator-framework:masterfrom
Closed
fix(e2e): Use Eventually for installplan status fetch operation#2394dinhxuanvu wants to merge 1 commit intooperator-framework:masterfrom
dinhxuanvu wants to merge 1 commit intooperator-framework:masterfrom
Conversation
Use `Eventually` to fetch installplan status to ensure the latest installplan being checked. Signed-off-by: Vu Dinh <vudinh@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
njhale
requested changes
Oct 5, 2021
Comment on lines
+3333
to
+3342
| if err != nil { | ||
| return false, err | ||
| } | ||
| if fetchedInstallPlan == nil { | ||
| return false, err | ||
| } | ||
| if hasCondition(fetchedInstallPlan, cond) { | ||
| return true, nil | ||
| } | ||
| return false, nil |
Member
There was a problem hiding this comment.
we can condense this legibly:
return fetchedInstallPlan != nil && hasCondition(fetchedInstallPlan, cond), err
openshift-ci
Bot
added
the
needs-rebase
|
@dinhxuanvu: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
This eventually statement was added in #2510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Eventuallyto fetch installplan status to ensure the latestinstallplan being checked.
Signed-off-by: Vu Dinh vudinh@outlook.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc