Skip to content

fix registry grpc unit test intermittent failure#2521

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
akihikokuroda:unitgrpc
Jan 3, 2022
Merged

fix registry grpc unit test intermittent failure#2521
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
akihikokuroda:unitgrpc

Conversation

@akihikokuroda
Copy link
Copy Markdown
Member

@akihikokuroda akihikokuroda commented Dec 12, 2021 •
edited
Loading

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:
The TestConnectionEvents test checks all the grpc connection state transitions but some intermidiate states are not captured correctly. This change checks the connection state moving to the ready state and check if there is any unexpected intermidiate states are observed in the transition.

Motivation for the change:
This error was seen in several CI build unit tests.
https://github.com/operator-framework/operator-lifecycle-manager/runs/4490427895?check_suite_focus=true
Closes ##2522

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 12, 2021

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2021
@akihikokuroda akihikokuroda mentioned this pull request Dec 13, 2021
Closed
5 tasks
@akihikokuroda akihikokuroda mentioned this pull request Dec 21, 2021
Merged
5 tasks
timflannagan
timflannagan reviewed Dec 22, 2021
View reviewed changes
Comment thread pkg/controller/registry/grpc/source_test.go Outdated
@akihikokuroda akihikokuroda mentioned this pull request Dec 23, 2021
Open
@awgreene
Copy link
Copy Markdown
Member

awgreene commented Dec 23, 2021

/approved

Great work on this @akihikokuroda

@timflannagan
Copy link
Copy Markdown
Member

timflannagan commented Dec 23, 2021

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 23, 2021
@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Dec 23, 2021

I had to resolve conflict. Then sanity errored.

timflannagan
timflannagan reviewed Dec 23, 2021
View reviewed changes
Comment thread pkg/controller/registry/grpc/source_test.go Outdated
timflannagan
timflannagan reviewed Dec 23, 2021
View reviewed changes
Comment thread pkg/controller/registry/grpc/source_test.go Outdated
@akihikokuroda akihikokuroda force-pushed the unitgrpc branch 2 times, most recently from 855927d to c2f2d3b Compare December 23, 2021 21:12
@timflannagan
Copy link
Copy Markdown
Member

timflannagan commented Dec 23, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2021
@timflannagan
Copy link
Copy Markdown
Member

timflannagan commented Dec 23, 2021

It looks like Alex misspelt the approve command so manually adding it 😆

@timflannagan timflannagan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: akihikokuroda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Jan 3, 2022

The e2e test failure is addressed in #2542

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

@akihikokuroda could you please rebase

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

@akihikokuroda I think you may need to run make format or make lint

@akihikokuroda
fix registry grpc unit test intermittent failure
10e8020 
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit ab923b3 into operator-framework:master Jan 3, 2022
@timflannagan timflannagan mentioned this pull request Jan 4, 2022
Closed
@akihikokuroda akihikokuroda mentioned this pull request Jan 11, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@awgreene awgreene Awaiting requested review from awgreene

1 more reviewer

@timflannagan timflannagan timflannagan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@perdasilva perdasilva

@timflannagan timflannagan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akihikokuroda @awgreene @timflannagan @openshift-bot @perdasilva @openshift-merge-robot