e2e CSV test - use unique name resources for each test#2541
e2e CSV test - use unique name resources for each test#2541openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
Conversation
|
Hi @akihikokuroda. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
akihikokuroda
changed the title
| }).Should(WithTransform(k8serrors.IsNotFound, BeTrue())) | ||
|
|
||
| Eventually(func() error { | ||
| return ctx.Ctx().Client().Delete(context.Background(), &ns) |
There was a problem hiding this comment.
I think this call is still prone to the previous behavior, but deleting the OG and CRD beforehand should smooth out the time that the namespace is hanging in the terminating status (on top of reducing the current flakiness of this test), and I don't have any better solutions poking around the code.
|
@akihikokuroda Can you also rebase when you get a chance? I saw the unit test failure, but we just merged those changes since this PR has been opened. |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
@akihikokuroda You may need to also rebase against master too. |
akihikokuroda
force-pushed
the
e2ecsv
branch
2 times, most recently
from
4ff1fe1 to
88cb720
Compare
|
/approve |
openshift-ci
Bot
added
the
approved
akihikokuroda
force-pushed
the
e2ecsv
branch
2 times, most recently
from
ad58d81 to
2600bc7
Compare
|
@akihikokuroda could you rebase this test as well? |
akihikokuroda
force-pushed
the
e2ecsv
branch
2 times, most recently
from
41a99cf to
40ea2d4
Compare
|
@akihikokuroda Apologies - we just merged some e2e improvements that parallelize the e2e suite into their own jobs, so the overall e2e execution should drop from ~1h to ~20m. Can you rebase your PR once more, and I'll tag it once it passes the checks? |
|
Longer term, we need to solve the situation where branches constantly need to be rebased when changes land in the master branch as it's not the greatest UX for contributors. |
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, awgreene, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com
The "ClusterServiceVersion when a CustomResourceDefinition was installed alongside a ClusterServiceVersion" tests uses the same namespace name for each test. It creates and remove the namespace every time. It doesn't delete the resources in the namespace before it delete the namespace. It may be causing the longer delete time of the namespace and the timeout of the test. The tests executed after the timeout fail because the uncleaned namespace and resources in it.
Description of the change:
Motivation for the change:
Closes #2540
Reviewer Checklist
/doc