Skip to content

put mutex around installplan creation#2545

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
akihikokuroda:createinstallplan
Jan 25, 2022
Merged

put mutex around installplan creation#2545
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
akihikokuroda:createinstallplan

Conversation

@akihikokuroda
Copy link
Copy Markdown
Member

@akihikokuroda akihikokuroda commented Dec 31, 2021

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:
This PR makes the check if the InstallPlan has to be created and the creation of the installplan in a locked block so that 2 namespace queue workers don't create the Installplan for the subscription.

Motivation for the change:

Closes #2544

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 31, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 31, 2021

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva
perdasilva reviewed Jan 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - it could be worth while to add some comments to explain why the lock is needed, maybe even reference the issue. Might help other people keep an eye on these types of race conditions, etc.

@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 2, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2022
@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Jan 3, 2022

The e2e test failure is addressed in #2542.

@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

@akihikokuroda could you please rebase

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@perdasilva
Copy link
Copy Markdown
Collaborator

perdasilva commented Jan 3, 2022

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2022
timflannagan
timflannagan reviewed Jan 4, 2022
View reviewed changes
Comment thread pkg/controller/operators/catalog/operator.go
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@timflannagan
Copy link
Copy Markdown
Member

timflannagan commented Jan 5, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2022
@akihikokuroda akihikokuroda mentioned this pull request Jan 11, 2022
Closed
6 tasks
@awgreene
Copy link
Copy Markdown
Member

awgreene commented Jan 14, 2022

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@akihikokuroda akihikokuroda force-pushed the createinstallplan branch 2 times, most recently from 257930c to 8b85bd1 Compare January 18, 2022 20:02
@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Jan 19, 2022

/retest

timflannagan
timflannagan reviewed Jan 19, 2022
View reviewed changes
Comment thread pkg/controller/operators/catalog/operator.go
@timflannagan
Copy link
Copy Markdown
Member

timflannagan commented Jan 24, 2022

@akihikokuroda Can you rebase this when you get a chance? I think this is ready to go.

@akihikokuroda
put mutex around installplan creation
2c47408 
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
timflannagan
timflannagan approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fe101a6 into operator-framework:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilva perdasilva perdasilva left review comments

@benluddy benluddy Awaiting requested review from benluddy

@gallettilance gallettilance Awaiting requested review from gallettilance

+1 more reviewer

@timflannagan timflannagan timflannagan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@perdasilva perdasilva

@timflannagan timflannagan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e Subscription "with starting CSV" error

5 participants

@akihikokuroda @perdasilva @timflannagan @awgreene @openshift-merge-robot