Makefile: Remove unused targets/variables#2567
Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom Jan 27, 2022
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Member
Author
|
/retest |
Member
|
The e2e error is probably fixed by #2561 |
timflannagan
force-pushed
the
cleanup/remove-unused-variable-makefile
branch
from
f72d14c to
b496083
Compare
timflannagan
force-pushed
the
cleanup/remove-unused-variable-makefile
branch
3 times, most recently
from
f8a5100 to
f627d10
Compare
Remove the unused "CONTROLLER_GEN" variable that was previously used to generate the CRD manifests before those APIs were moved to the operator-framework/api repository. Update the root Makefile and remove any obvious .PHONY unused targets (or redundant targets). Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
cleanup/remove-unused-variable-makefile
branch
from
f627d10 to
51c1d39
Compare
Contributor
|
Nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Remove the unused "CONTROLLER_GEN" variable that was previously used to
generate the CRD manifests before those APIs were moved to the
operator-framework/api repository. Update the root Makefile and remove
any obvious .PHONY unused targets (or redundant targets).
Signed-off-by: timflannagan timflannagan@gmail.com
Motivation for the change:
Cleanup
Reviewer Checklist
/doc