(e2e-fix) do not check for updated csv that is likely to be GC'd#2837
Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom Aug 10, 2022
Merged
Conversation
In the test `Operator Group cleanup csvs with bad namespace annotation`, the polling logic that updates a copied csv with a bad annotation was checking to see if the update was successful. However, once the copied csv is given a bad annotation, the CSV is GC'd, and if the collection happens immediately, the polling logic fails. This fix removes the logic that attempts to check the updated CSV, and instead relies on the updateErr being nil to assert that the update was successful. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
force-pushed
the
bad-csv-gc-gcp-fix
branch
from
a9f8aae to
9519bd1
Compare
timflannagan
approved these changes
Aug 10, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
In the test
Operator Group cleanup csvs with bad namespace annotation, the pollinglogic that updates a copied csv with a bad annotation was checking to see if the
update was successful. However, once the copied csv is given a bad annotation, the CSV
is GC'd, and if the collection happens immediately, the polling logic fails. This fix
removes the logic that attempts to check the updated CSV, and instead relies on the
updateErr being nil to assert that the update was successful.
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue