Skip to content

OCPBUGS-17157: controller/registry: don't set memory limits for target#3015

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
stevekuznetsov:skuznets/no-limits
Aug 21, 2023
Merged

OCPBUGS-17157: controller/registry: don't set memory limits for target#3015
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
stevekuznetsov:skuznets/no-limits

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented Aug 18, 2023

It's not allowed for core components to have memory limits, to ensure that that source of crash-looping pods does not occur to the core payload.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 18, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Aug 18, 2023

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17791, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

It's not allowed for core components to have memory limits, to ensure that that source of crash-looping pods does not occur to the core payload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from ecordell and tmshort August 18, 2023 13:04
This was referenced Aug 18, 2023
Closed
Merged
@stevekuznetsov
controller/registry: don't set memory limits for target
a7f6bad 
It's not allowed for core components to have memory limits, to ensure
that that source of crash-looping pods does not occur to the core
payload.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@awgreene
Copy link
Copy Markdown
Member

awgreene commented Aug 21, 2023

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 21, 2023

Need to update the bug to include 4.14.0 to fix the jira label.

@stevekuznetsov stevekuznetsov changed the title OCPBUGS-17791: controller/registry: don't set memory limits for target OCPBUGS-17157: controller/registry: don't set memory limits for target Aug 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Aug 21, 2023

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

It's not allowed for core components to have memory limits, to ensure that that source of crash-looping pods does not occur to the core payload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianzhangbjz August 21, 2023 15:52
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 21, 2023

Had it on the wrong bug, oops

@openshift-merge-robot openshift-merge-robot merged commit ff0baf4 into operator-framework:master Aug 21, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Aug 21, 2023

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

Details

In response to this:

It's not allowed for core components to have memory limits, to ensure that that source of crash-looping pods does not occur to the core payload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecordell ecordell Awaiting requested review from ecordell

@tmshort tmshort Awaiting requested review from tmshort

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@awgreene awgreene

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevekuznetsov @openshift-ci-robot @awgreene @tmshort @openshift-merge-robot