Skip to content

Add test comment back#3118

Merged
awgreene merged 1 commit intooperator-framework:masterfrom
awgreene:add-test-info-back
Nov 20, 2023
Merged

Add test comment back#3118
awgreene merged 1 commit intooperator-framework:masterfrom
awgreene:add-test-info-back

Conversation

@awgreene
Copy link
Copy Markdown
Member

@awgreene awgreene commented Nov 20, 2023 •
edited
Loading

This commit reintroduces test documentation accidentally removed in #3042

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci Bot requested review from benluddy and tmshort November 20, 2023 20:39
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@awgreene
Add test comment back
69f802f 
This commit reintroduces test documentation accidentally removed in
operator-framework#3042

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented Nov 20, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@awgreene awgreene added this pull request to the merge queue Nov 20, 2023
Merged via the queue into operator-framework:master with commit 5431679 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@tmshort tmshort Awaiting requested review from tmshort

Assignees

@dtfranz dtfranz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awgreene @dtfranz