deploy: use Recreate strategy for Deployments

[stevekuznetsov]

deploy: use Recreate strategy for Deployments

Our controllers must not share runtime with controllers of previous
versions, as we expect that the set of actors on the cluster to be
coherent with respect to what they're trying to do. RollingUpdate
strategies do not guarantee this and lead to cases where previous
versions of the operators issue spurious mutating calls that the
current operator needs to un-do.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

---

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-25448, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

deploy: use Recreate strategy for Deployments

Our controllers must not share runtime with controllers of previous
versions, as we expect that the set of actors on the cluster to be
coherent with respect to what they're trying to do. RollingUpdate
strategies do not guarantee this and lead to cases where previous
versions of the operators issue spurious mutating calls that the
current operator needs to un-do.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

/jira refresh

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-25448, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[everettraven]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@stevekuznetsov: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

deploy: use Recreate strategy for Deployments

Our controllers must not share runtime with controllers of previous
versions, as we expect that the set of actors on the cluster to be
coherent with respect to what they're trying to do. RollingUpdate
strategies do not guarantee this and lead to cases where previous
versions of the operators issue spurious mutating calls that the
current operator needs to un-do.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ncdc]

Manually merging to get past CI flakes.