Revert "Fix unpack job cache issue (#3204)"#3211
Merged
dinhxuanvu merged 1 commit intooperator-framework:masterfrom Apr 25, 2024
Merged
Revert "Fix unpack job cache issue (#3204)"#3211dinhxuanvu merged 1 commit intooperator-framework:masterfrom
dinhxuanvu merged 1 commit intooperator-framework:masterfrom
Conversation
This reverts commit 47aaa6b.
Member
|
Well, for this list call, you should use this func On a related note, there is no point to update the pod given the pod is created by the job. The proper flow should be to delete the pod and the job and then recreate the job in case of failed pod or in case of rerunning the job (the job cannot be rereun without recreating). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 47aaa6b.
We previously thought this would:
Instead we've found that jobs created in 4.14 already meet the requirements to be listed by the labeller and that also updating the jobs in this manner can be detrimental because every field in the pod template is immutable and thus generates lots of errors when the update runs.
We'll need to find out why the jobs aren't getting listed and how to handle that in this case in another way. We think the root cause has something to do with the filtering we do here.