abandon evaluation of any new catalogsource image which is pathological#3766
Merged
openshift-merge-bot[bot] merged 2 commits intooperator-framework:masterfrom Feb 19, 2026
Merged
Conversation
…y restrts Signed-off-by: grokspawn <jordan@nimblewidget.com>
joelanford
reviewed
Feb 12, 2026
joelanford
reviewed
Feb 12, 2026
Signed-off-by: grokspawn <jordan@nimblewidget.com>
grokspawn
force-pushed
the
fix-wedged-newcat-eval
branch
from
9985929 to
1098551
Compare
grokspawn
changed the title
joelanford
approved these changes
Feb 19, 2026
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
/approve
Just the one (nit) question about the crashloopbackoff constant.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit feecd01
into
operator-framework:master
14 checks passed
Collaborator
|
Fix included in accepted release 4.22.0-0.nightly-2026-03-02-153725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR adds a pathological status check for when container status indicates crashloopbackoff.
If that status matches, OLM will abandon catalog evaluation for that image, dispose of the pod, and pull a new image when the
pollIntervalcomes up again.This will now cause the catalog operator to emit a message of the form
and the offending pod will be deleted.
Motivation for the change:
In the case that a catalogsource defines
.spec.grpcPodConfig.extractContentit is possible for OLMv0 to get trapped in an evaluation loop if the catalogsource is not compatible with the on-cluster catalogsource service.This is because the on-cluster catalog services which use
extractContentdefine two initContainers and a service container. When those initContainers succeed, the pod status progresses to RUNNING regardless of the success/failure of the service container.If the service container fails, it will halt, and the pod will start being rebooted by kube when it fails readiness/liveness probes. It will remain in RUNNING status, so OLM will requeue its evaluation without end.
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue