Remove Namespace Annotator #559
Conversation
openshift-ci-robot
added
the
size/XL
|
/retest |
|
/approve |
openshift-ci-robot
added
approved
alecmerdler
force-pushed
the
remove-ns-annotator
branch
from
c88a811 to
3d33e09
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alecmerdler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test unit |
njhale
left a comment
njhale
left a comment
There was a problem hiding this comment.
Found out what's blocking the unit tests from succeeding.
| csvQueue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "clusterserviceversions"), | ||
| annotator: namespaceAnnotator, | ||
| recorder: eventRecorder, | ||
| cleanupFunc: func() { |
There was a problem hiding this comment.
The cleanup func needs to go too.
|
see: #563 |
4 participants
Description
It's no longer being used. The UI was updated in openshift/console#776.