Skip to content

Always set LastTransitionTime in OperatorStatusCondition#830

Merged
openshift-merge-robot merged 1 commit into
operator-framework:masterfrom
soltysh:fix_nil
Apr 29, 2019
Merged

Always set LastTransitionTime in OperatorStatusCondition#830
openshift-merge-robot merged 1 commit into
operator-framework:masterfrom
soltysh:fix_nil

Conversation

@soltysh
Copy link
Copy Markdown

@soltysh soltysh commented Apr 29, 2019

This PR is fixing the problem spotted in openshift/cluster-version-operator#168:

Unable to update cluster operator status: ClusterOperator.config.openshift.io \"operator-lifecycle-manager\" is invalid: []: Invalid value: map[string]interface {}{\"kind\":\"ClusterOperator\", \"metadata\":map[string]interface {}{\"uid\":\"a694fc84-68d4-11e9-a00d-125e210e6730\", \"generation\":1, \"creationTimestamp\":\"2019-04-27T10:10:14Z\", \"resourceVersion\":\"4564\", \"name\":\"operator-lifecycle-manager\"}, \"spec\":map[string]interface {}{}, \"apiVersion\":\"config.openshift.io/v1\", \"status\":map[string]interface {}{\"extension\":interface {}(nil), \"conditions\":[]interface {}{map[string]interface {}{\"type\":\"Degraded\", \"status\":\"False\", \"lastTransitionTime\":\"2019-04-27T10:10:14Z\"}, map[string]interface {}{\"message\":\"Deployed 0.9.0\", \"type\":\"Progressing\", \"status\":\"True\", \"lastTransitionTime\":interface {}(nil)}, map[string]interface {}{\"type\":\"Available\", \"status\":\"True\", \"lastTransitionTime\":\"2019-04-27T10:10:14Z\"}}, \"versions\":[]interface {}{map[string]interface {}{\"version\":\"0.0.1-2019-04-27-095238\", \"name\":\"operator\"}, map[string]interface {}{\"name\":\"operator-lifecycle-manager\", \"version\":\"0.9.0\"}}}}: validation failure list:\nstatus.conditions.lastTransitionTime in body must be of type string: \"null\""

/assign @ecordell

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2019
@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 29, 2019

/retest

@ecordell
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2019
@ecordell
Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Copy Markdown
Member

/test e2e-aws-olm

@ecordell
Copy link
Copy Markdown
Member

/retest

2 similar comments
@ecordell
Copy link
Copy Markdown
Member

/retest

@ecordell
Copy link
Copy Markdown
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 95910da into operator-framework:master Apr 29, 2019
@soltysh soltysh deleted the fix_nil branch April 30, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants