Update openshift api#172
Conversation
-Update the vendored dependency to github.com/openshift/api `dep ensure -update github.com/openshift/api` -Update the vendored dependency to github.com/openshift/client-go as a prerequisite `dep ensure -update github.com/openshift/client-go`
openshift-ci-robot
added
the
size/XXL
|
/cc @soltysh @jwforres @awgreene @galletti94 @anik120 @SamiSousa @JEREMYLINLIN Trying to put as many eyes on this one as possible. Thanks guys. |
openshift-ci-robot
requested review from
SamiSousa,
anik120,
awgreene,
gallettilance and
jeremy-wl
|
@kevinrizza: GitHub didn't allow me to request PR reviews from the following users: soltysh, jwforres. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
awgreene
left a comment
awgreene
left a comment
There was a problem hiding this comment.
Good work on this @kevinrizza, one nit.
| @@ -339,7 +339,7 @@ func (s *status) monitorClusterStatus() { | |||
| case <-s.stopCh: | |||
| // If the stopCh is closed, the operator will exit and CO should | |||
| // be set to failing. | |||
There was a problem hiding this comment.
This should say
// be set to degrading
-Updated all references of (`"github.com/openshift/api/config/v1"`) configv1.OperatorFailing to configv1.OperatorDegraded -Updated comments, functions, and variable names to match
kevinrizza
force-pushed
the
update-openshift-api
branch
from
29a4036 to
c8b3476
Compare
|
/retest |
|
/test e2e-aws-upgrade |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, soltysh, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
6 participants
This pull requests migrates the vendored dependency of the
openshift/apiproject to the latest.This is being done in preparation for the release of Openshift 4.1
-Update the vendored dependency to github.com/openshift/api
dep ensure -update github.com/openshift/api-Update the vendored dependency to github.com/openshift/client-go as a
prerequisite
dep ensure -update github.com/openshift/client-go-Updated all references of (
"github.com/openshift/api/config/v1")configv1.OperatorFailing to configv1.OperatorDegraded
-Updated comments, functions, and variable names to match