OPECO-2596: semver should generate replaces across Y-streams in minor-channel mode

[theishshah]

This PR contains the initial logic and docs for cleaning up the FBC Z-stream replacements. Follow up work for this PR will include a unit testing deep dive spike and some re-factoring to pre-sort and filter versions.

Closes #1031

streamlining & add'l namechanges to working utest, debug printfs removed
working idempotent approach across set of all channel entries; but gaps in utest and UGLY implementation refactor minimally-nested ifs
updated supporting docs
standardize on yaml.UnmarshallStrict to give better diagnostics for unexpected fields

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: theishshah
Once this PR has been reviewed and has the lgtm label, please assign njhale for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

Would you please retitle to something like OPECO-2596: semver should generate replaces across Y-streams in minor-channel mode and add solves #1031 ?

[openshift-ci-robot]

@theishshah: This pull request references OPECO-2596 which is a valid jira issue.

Details

In response to this:

This PR contains the initial logic and docs for cleaning up the FBC Z-stream replacements. Follow up work for this PR will include a unit testing deep dive spike and some re-factoring to pre-sort and filter versions.

streamlining & add'l namechanges to working utest, debug printfs removed
working idempotent approach across set of all channel entries; but gaps in utest and UGLY implementation refactor minimally-nested ifs
updated supporting docs
standardize on yaml.UnmarshallStrict to give better diagnostics for unexpected fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[everettraven]

Overall looks pretty good, great work @theishshah!

The reason for me marking this review as requesting changes is some minor things I found in how the tests are written that I think could be contributing to the test failures.

Aside from that I had a few smaller nits.

[codecov]

Codecov Report

Merging #1065 (d7edf24) into master (fe51230) will increase coverage by 0.04%.
The diff coverage is 85.71%.

❗ Current head d7edf24 differs from pull request most recent head e970b8b. Consider uploading reports for the commit e970b8b to get more accurate results

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   52.75%   52.79%   +0.04%     
==========================================
  Files         106      107       +1     
  Lines        9378     9381       +3     
==========================================
+ Hits         4947     4953       +6     
+ Misses       3517     3511       -6     
- Partials      914      917       +3     

Impacted Files	Coverage Δ
alpha/declcfg/write.go	75.38% <ø> (ø)
alpha/template/semver/types.go	80.00% <80.00%> (ø)
alpha/template/semver/semver.go	66.16% <86.11%> (+1.63%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[openshift-ci-robot]

@theishshah: This pull request references OPECO-2596 which is a valid jira issue.

Details

In response to this:

This PR contains the initial logic and docs for cleaning up the FBC Z-stream replacements. Follow up work for this PR will include a unit testing deep dive spike and some re-factoring to pre-sort and filter versions.

Closes #1031

streamlining & add'l namechanges to working utest, debug printfs removed
working idempotent approach across set of all channel entries; but gaps in utest and UGLY implementation refactor minimally-nested ifs
updated supporting docs
standardize on yaml.UnmarshallStrict to give better diagnostics for unexpected fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.