Skip to content

OCPBUGS-32863: removing docker registry replace#1243

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
grokspawn:docker-registry-bump
Mar 28, 2024
Merged

OCPBUGS-32863: removing docker registry replace#1243
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
grokspawn:docker-registry-bump

Conversation

@grokspawn
Copy link
Copy Markdown
Contributor

Description of the change:

removing

replace github.com/docker/distribution => github.com/docker/distribution v0.0.0-20191216044856-a8371794149d

from go.mod

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci Bot requested review from njhale and theishshah March 28, 2024 18:22
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@grokspawn grokspawn force-pushed the docker-registry-bump branch from d1459a9 to e08a949 Compare March 28, 2024 18:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.02%. Comparing base (e5bba5f) to head (09370e7).

❗ Current head 09370e7 differs from pull request most recent head e08a949. Consider uploading reports for the commit e08a949 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   54.02%   54.02%           
=======================================
  Files         108      108           
  Lines       11266    11266           
=======================================
  Hits         6087     6087           
  Misses       4190     4190           
  Partials      989      989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Copy Markdown
Contributor Author

/hold until we get some consensus about adopting alpha distribution/distribution/v3.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@grokspawn grokspawn force-pushed the docker-registry-bump branch 2 times, most recently from 09370e7 to e08a949 Compare March 28, 2024 19:21
Copy link
Copy Markdown
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: API diff:
github.com/docker/distribution redirects to github.com/distribution/distribution, so it shouldn't be too big of a deal.
re: codecov:
very minor, not concerned

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Mar 28, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit e30273d into operator-framework:master Mar 28, 2024
@grokspawn grokspawn deleted the docker-registry-bump branch March 28, 2024 19:38
@kevinrizza kevinrizza changed the title removing docker registry replace OCPBUGS-32863: removing docker registry replace Apr 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@grokspawn: Jira Issue OCPBUGS-32863: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32863 has been moved to the MODIFIED state.

Details

In response to this:

Description of the change:

removing

replace github.com/docker/distribution => github.com/docker/distribution v0.0.0-20191216044856-a8371794149d

from go.mod

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants