Remove package manifest parsing#137
Merged
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom Dec 20, 2019
Merged
Remove package manifest parsing#137openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
Conversation
added 2 commits
December 17, 2019 15:58
Also, switch the bundle to be an api.Bundle, which is step towards avoiding parsing of the CSV and relying solely on the catalog.
openshift-ci-robot
added
approved
Author
|
/retest |
3 similar comments
Author
|
/retest |
Author
|
/retest |
Author
|
/retest |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Package manifest parsing has been removed and this switches the bundle object to be closer to what is used by the registry.
Motivation for the change:
This cleans up a follow up requested last dev sprint: #92 (review). But more importantly, this PR is a per-requisite for launching bundle images in OLM: operator-framework/operator-lifecycle-manager#1081.
Reviewer Checklist
/docs