provide an optional base image flag for generated dockerfiles from alpha bundle build commands#1519
Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom Dec 17, 2024
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ndle build commands Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
fe99e6f to
f6cf01e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
- Coverage 48.61% 46.80% -1.82%
==========================================
Files 135 135
Lines 12793 15760 +2967
==========================================
+ Hits 6219 7376 +1157
- Misses 5533 7343 +1810
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR adds an optional "base-image" flag to
opm alpha bundle generate. This results in some breaking changes for possible clients which now must pass a new parameter"scratch"to produce previous behavior.Motivation for the change:
Some clients prefer to use base images other than
scratch. This is the lightest-touch approach I could use to provide this.Reviewer Checklist
/docs