release/goreleaser.opm.Dockerfile: parameterize grpc-health-probe version#1801
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 55.27% 55.27%
=======================================
Files 136 136
Lines 15976 15976
=======================================
Hits 8830 8830
Misses 5991 5991
Partials 1155 1155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…sion Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
32818b4 to
ba219cb
Compare
|
/approve |
rashmigottipati
left a comment
There was a problem hiding this comment.
/lgtm
optional (nit): it might be good to add in the docs that manual docker builds now require a --build-arg to specify the GRPC_HEALTH_PROBE_VERSION
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a5f1128
into
operator-framework:master
Description of the change:
Parameterize and use the go.mod
grpc-health-probeversion in the goreleaser-builtquay.io/operator-framework/opm.Motivation for the change:
This will help us keep the grpc-health-probe version up-to-date in the
opmimage. Dependabot is already helping us keep thegrpc-health-probego dependency up-to-date, so this PR means that that automation will now automatically propagate to the version used in the image.Reviewer Checklist
/docs