handle cases where spec.version.release is a number instead of string#1909
Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: grokspawn <jordan@nimblewidget.com> Assisted-By: claude
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
+ Coverage 57.44% 57.48% +0.03%
==========================================
Files 139 139
Lines 13323 13328 +5
==========================================
+ Hits 7653 7661 +8
+ Misses 4488 4485 -3
Partials 1182 1182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
reviewed
Feb 23, 2026
| Spec: json.RawMessage(`{"release": true}`), | ||
| }, | ||
| wantErr: true, | ||
| }, |
Contributor
There was a problem hiding this comment.
is it worth exercising the {"release": ""} case?
Contributor
|
/approve |
openshift-ci
Bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit f410a39
into
operator-framework:master
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-By: claude
Description of the change:
explicitly handles the case where a CSV's spec.release version is represented as an int or float instead of a string.
Motivation for the change:
while the tooling in operator-framework should always steer towards CSVs which use string release values, there remain a variety of ways to generate a CSV which might result in a numerical value for release. So we need to provide a more flexible import approach to encompass these capabilities.
Reviewer Checklist
/docs