-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improve annotation watch-based on SDK #2962
Copy link
Copy link
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.needs discussion
Milestone
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.needs discussion
Feature Request
Context
We did the pull request for upstream and some feedbacks were made. In the end, the pr was closed because we reach a consensus that it is not generic enough to upstream. The idea of this task is for we incorporate the improvements made in upstream to the current code in SDK. See the PR: kubernetes-sigs/controller-runtime#892
Improvements to incorporate
Notes