Skip to content

Improve annotation watch-based on SDK #2962

@camilamacedo86

Description

@camilamacedo86

Feature Request

Context
We did the pull request for upstream and some feedbacks were made. In the end, the pr was closed because we reach a consensus that it is not generic enough to upstream. The idea of this task is for we incorporate the improvements made in upstream to the current code in SDK. See the PR: kubernetes-sigs/controller-runtime#892

Improvements to incorporate

  • Bring the test done to cover the feature
  • The GK owner-annotation use the schema instead of allowing any string
  • Bring the helper to add the annotations
  • Bring the docs/comments
  • Replace the places in SDK to add the annotation via the help bring.

Notes

Metadata

Metadata

Labels

kind/featureCategorizes issue or PR as related to a new feature.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.needs discussion

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions