-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add flag metrics-addr for Helm/Ansible #3358
Copy link
Copy link
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.kubebuilder-integrationRelates to rewriting the SDK in Kubebuilder plugin formRelates to rewriting the SDK in Kubebuilder plugin formlanguage/ansibleIssue is related to an Ansible operator projectIssue is related to an Ansible operator projectlanguage/helmIssue is related to a Helm operator projectIssue is related to a Helm operator project
Milestone
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.kubebuilder-integrationRelates to rewriting the SDK in Kubebuilder plugin formRelates to rewriting the SDK in Kubebuilder plugin formlanguage/ansibleIssue is related to an Ansible operator projectIssue is related to an Ansible operator projectlanguage/helmIssue is related to a Helm operator projectIssue is related to a Helm operator project
Feature Request
The new helm layout is working with the current/legacy image of the operator-sdk helm. This image is not allowing users to customize the metrics port.
We need to:
cmd/helm|ansible-operator/main.gowhich is used to generate bin. See: [ansible/helm] remove operator-sdk binary from ansible/helm base images #3331internal/plugins/helm/v1/scaffolds/templates/metricsauth/auth_proxy_patch.go) to use the enableLeaderElection flag. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugin/v3/scaffolds/internal/templates/metricsauth/auth_proxy_patch.go#L68-L70Important: we should scaffold the projects to use by default the same go/kb port in order to keep a standard across all projects and then, describe in the migration guide how the users are able to still use the current port and no face breaking changes if they wish.