Nit: I know this is a backport and this line is basically unchanged in this PR but for better readability this probably should be:
Expect(err).NotTo(HaveOccurred())
Succeed() is used more for the function itself:
Ω(DoSomethingSimple()).Should(Succeed())
https://onsi.github.io/gomega/#handling-errors
Originally posted by @hasbro17 in #3895 (comment)
Originally posted by @hasbro17 in #3895 (comment)