Discuss the behavior of operator-sdk new

[fanminshi]

Current runoperator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService creates a new folder called app-operator. If I call operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService, the command overrides everything there is in the app-operator folder. I don't think that's behavior we want. In rails, the new command skips any files that have been created and generates the ones that aren't there. The rails behavior seems great but might complicate the current operator-sdk new code base to support that. I think the simpler way is to check if app-operator folder has been created already; if not, create it; if created, then skip the files and dirs creation.

cc/ @hasbro17 @hongchaodeng

[hongchaodeng]

It depends.
For the behavior, if the input is deterministic, and output is deterministic, then it is safe to skip anything that already exists.

if app-operator folder has been created already

IMHO, this is not enough to determine if the output is what we want to generate.

[hasbro17]

this is not enough to determine if the output is what we want to generate

@hongchaodeng Can you explain your concern a bit more.

I was thinking that the expected behavior from operator-sdk new <project-name> is to simply create a new project if it does not exist.
So there are two cases:

• If a directory with <project-name> already exists in the current working directory then the command should output an error saying it already exists. Doesn't matter are the contents of that directory.
• If there is no directory, then create a new project.

[hongchaodeng]

I think the solution @hasbro17 mentioned above is good enough.

Can you explain your concern a bit more.

Not really a concern. As mentioned above, in order to skip some files and generate the rest, it needs both the input and output to be deterministic. Just checking the folder exists not enough.

[hasbro17]

Sounds good. @fanminshi We'll proceed with the above mentioned behavior for now.

[fanminshi]

yep!

[fanminshi]

fixed via #85