Skip to content

commands/operator-sdk: add flags check#106

Merged
fanminshi merged 1 commit intooperator-framework:masterfrom
fanminshi:add_flag_check
Mar 9, 2018
Merged

commands/operator-sdk: add flags check#106
fanminshi merged 1 commit intooperator-framework:masterfrom
fanminshi:add_flag_check

Conversation

@fanminshi
Copy link
Copy Markdown
Contributor

@fanminshi fanminshi commented Mar 9, 2018 •
edited
Loading

add checks to guard invalid flags values for --api-version and --kind

@fanminshi
Copy link
Copy Markdown
Contributor Author

fanminshi commented Mar 9, 2018

Manual Test:

# Test case: empty --api-version
$ operator-sdk new memcached-operator --api-version="" --kind="123"
Error: --api-version must not have empty value

# Test case: empty --kind
$ operator-sdk new memcached-operator --api-version="123" --kind=""
Error: --kind must not have empty value

# Test case: invalid --api-version
$ operator-sdk new memcached-operator --api-version="123" --kind="123"
Error: api-version has wrong format (123); format must be $GROUP_NAME/$VERSION (e.g app.example.com/v1alpha1)

@fanminshi
Copy link
Copy Markdown
Contributor Author

fanminshi commented Mar 9, 2018

cc/ @hasbro17

@hasbro17
Copy link
Copy Markdown
Contributor

hasbro17 commented Mar 9, 2018

LGTM

@fanminshi fanminshi merged commit 48caa79 into operator-framework:master Mar 9, 2018
@fanminshi fanminshi mentioned this pull request Mar 10, 2018
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanminshi @hasbro17