Skip to content

pkg/scaffold: move to internal/pkg/scaffold #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joelanford merged 11 commits into from
Mar 28, 2019
Merged

pkg/scaffold: move to internal/pkg/scaffold #1182

joelanford merged 11 commits into from
Mar 28, 2019

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Mar 7, 2019 •
edited
Loading

Description of the change:
Moving pkg/scaffold to internal/pkg/scaffold

Motivation for the change:
Necessary for 1.0.0 release and closes #756

@joelanford joelanford added this to the 1.0.0 milestone Mar 7, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2019
@joelanford joelanford changed the title pkg/scaffold: move to internal/scaffold pkg/scaffold: move to internal/pkg/scaffold Mar 19, 2019
lilic
lilic suggested changes Mar 20, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the link as well to point to the newly moved file. -> https://raw.githubusercontent.com/operator-framework/operator-sdk/f5d68dbc68b919ac1cf179faf2110fb672473f98/doc/user/logging.md

lilic
lilic approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

hasbro17
hasbro17 approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estroz
estroz approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating doc link.

@joelanford
Copy link
Member Author

joelanford commented Mar 28, 2019

/test marker

@joelanford
Copy link
Member Author

joelanford commented Mar 28, 2019

@estroz are you referring to the flaky marker test (now looks ok) or something else?

@estroz
Copy link
Member

estroz commented Mar 28, 2019

The marker test. Didn't know it was flaky 🤕.

@joelanford joelanford merged commit 4564a35 into operator-framework:master Mar 28, 2019
@joelanford joelanford deleted the v1-scaffold branch March 29, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@theishshah theishshah Awaiting requested review from theishshah

3 more reviewers

@lilic lilic lilic approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz estroz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not expose pkg/scaffold

5 participants

@joelanford @estroz @lilic @hasbro17 @openshift-ci-robot