cmd/.../scorecard: move scorecard libraries out of cmd

[AlexNPavel]

Description of the change: This PR moves most of the files/functions from cmd/operator-sdk/scorecard into internal/pkg/scorecard, moves the individual test definitions from test_definitions.go into the the basic_tests.go and olm_tests.go files, and exposes the struct definitions in test_definitions.go through pkg/scorecard/lib.

Motivation for the change: The scorecard shouldn't be sitting entirely in the cmd directory, especially for certain struct definitions that other developers may want to use when developing scorecard plugins. This also makes simplifies some of the future implementation work needed for the scorecard plugin system defined in doc/proposals/scorecard-plugin-system.md.

[estroz]

/lgtm

after addressing other comments.

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[AlexNPavel]

/cc @joelanford @lilic PTAL

[openshift-ci-robot]

@AlexNPavel: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @joelanford @lilic PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

lgtm

[joelanford]

I'm wondering if we should move pkg/scorecard/test_definitions.go to internal/pkg/scorecard for now since those definitions are currently only used internally.

With v1.0.0 on the horizon, the upcoming scorecard plugin implementation, and the discussions that the OLM and Marketplace teams are having around the container verification pipeline (CVP) and operator tooling UX, I'm thinking it might be worth waiting to see if: a) these need to be exported, and b) if so, if they'll need to change as other related pieces mature.

Thoughts?

[AlexNPavel]

I think it would be fine to keep those internal for now and expose them later if we feel that it's necessary

[AlexNPavel]

I've moved the test_definitions.go file into internal as well. PTAL

/cc @joelanford

[joelanford]

LGTM