-
Notifications
You must be signed in to change notification settings - Fork 1.8k
deps: bump to controller-runtime v0.2.0, kubernetes-1.14.1, and helm v2.14.1 #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump to controller-runtime v0.2.0, kubernetes-1.14.1, and helm v2.14.1 #1512
Conversation
internal/pkg/scorecard/scorecard.go
Outdated
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/apimachinery/pkg/runtime/serializer" | ||
| "k8s.io/client-go/discovery/cached" | ||
| cached "k8s.io/client-go/discovery/cached" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler throws errors if there's no build identifier.
|
/test marker |
|
@camilamacedo86 @estroz Whichever PR lands in, we need a migration doc, I guess we can do this in a parallel PR for ease of reviewing? |
|
Also, what did we decide on what to do with this PR? Sit on it? Merge it into a separate branch? Merge it into master? Right now looks like it's targetting |
|
@joelanford IIRC we agreed to merge with master because the original |
|
@estroz Haha. I thought I heard the opposite based on the same premise. What I heard was "The separate branch for the original controller-runtime migration was a pain. Since the changes this time around are minimal relative to last time, a separate branch shouldn't be a big deal." If we merge this to |
|
Hi @estroz, Could you add here the follow commit? And upgrade the following deps as well? [[constraint]]
name = "github.com/sirupsen/logrus"
version = "1.4.2"
[[constraint]]
name = "github.com/spf13/cobra"
version = "0.0.4"Also, I think you can use the Changelog and just update the commit number c5bdaee Really tks for the help on it 👍 |
|
@joelanford very possible I heard incorrectly. I'll make a refactor branch like we did last time. |
1b7b8d9 to
f0f35cc
Compare
joelanford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Not sure how to handle the difference in version numbers in the CHANGELOG since #1612 was merged. So if those suggestions don't make sense, you can ignore them. Should we merge master into refactor/controller-runtime-v0.2.0?
|
New changes are detected. LGTM label has been removed. |
hasbro17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one comment on the removed replace directive for the prometheus-operator dependency in go.mod.
5912ff4 to
8e6dd4c
Compare
8e6dd4c to
d9b89bb
Compare
Update the underlying operator-sdk to v0.11.x. The new version contains version v0.2.0 which introduces a new feature to watch multiple namesapces. This is needed to implement #20. For more information see operator-framework/operator-sdk#1512.
Description of the change: bump
controller-runtimetov0.2.0andhelmto2.14.0, both of which depend onkubernetes-1.14.xdependencies.Motivation for the change: from #1388: