README.md: Add missing --repo flag in quickstart#1713
Merged
estroz merged 1 commit intooperator-framework:masterfrom Jul 29, 2019
Merged
README.md: Add missing --repo flag in quickstart#1713estroz merged 1 commit intooperator-framework:masterfrom
estroz merged 1 commit intooperator-framework:masterfrom
Conversation
In 757f7a0 the `--repo` flag was added to the `operator-sdk new` command, which is required when running with `--dep-manager modules`. This breaks the Go quickstart since `--repo` isn't mentioned there.
openshift-ci-robot
added
the
size/XS
|
Hi @johananl. Thanks for your PR. I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
Member
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 757f7a0 the
--repoflag was added to theoperator-sdk newcommand, which is required when running with--dep-manager modules. This breaks the Go quickstart since--repoisn't mentioned there.Closes #1688.
Description of the change:
Include the
--repoflag in the Go quickstart.Motivation for the change:
Docs should be accurate.