*: refactor CRD/API getters #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
fabianvf,
hasbro17,
jmrodri,
joelanford and
theishshah
openshift-ci-robot
added
the
size/L
hasbro17
reviewed
Aug 8, 2019
hasbro17
reviewed
Aug 8, 2019
hasbro17
reviewed
Aug 8, 2019
hasbro17
reviewed
Aug 8, 2019
hasbro17
reviewed
Aug 8, 2019
hasbro17
reviewed
Aug 8, 2019
Member
Author
|
/test e2e-aws-go |
hasbro17
reviewed
Aug 9, 2019
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
pkg/apis/<group>.Motivation for the change: with CRD manifest name changes and general work being done to bump controller-runtime to v0.2.0, several changes are being made to how the SDK parses CRD manifests and APIs. These changes are necessary for updates made in #1642 and follow-up PR's.