internal/pkg/scaffold: update go.mod scaffolds and fix prometheus module resolution #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
fabianvf,
hasbro17,
jmrodri,
joelanford and
theishshah
openshift-ci-robot
added
the
size/L
Member
Author
|
/retest |
joelanford
reviewed
Aug 6, 2019
joelanford
reviewed
Aug 7, 2019
estroz
force-pushed
the
fix-dependencies
branch
from
37458f1 to
1f1dda4
Compare
Member
Author
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
theishshah
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: https://proxy.golang.org seems to have recently begun disallowing incorrectly versioned modules v2+. Prometheus is one of those modules, as it is v2+ and does not have a
/v2at the end of its go.mod'smodulepath. We can use this temporary fix until themodulepath is fixed upstream.Scaffold tests have been removed because they do not test anything.