Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Aug 10, 2019

Description of the change: CR manifest name changes from #1642.

Motivation for the change: keep CR manifest file names in line with CRD file names (full group instead of group).

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2019
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 0fda655 into operator-framework:refactor/controller-runtime-v0.2.0 Aug 12, 2019
@estroz estroz deleted the cr-name-format-c-r-v0.2.0 branch August 12, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants