pkg/ansible/controller/reconcile.go: fix invalid logger.Info usage#2031
Merged
joelanford merged 2 commits intooperator-framework:masterfrom Oct 10, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/XS
joelanford
added
kind/bug
Contributor
|
/test e2e-aws-ansible |
camilamacedo86
added
the
approved
theishshah
pushed a commit
that referenced
this pull request
Oct 10, 2019
* cherry picked commit * backport second bug fix * revert previous backport
fabianvf
pushed a commit
to fabianvf/operator-sdk
that referenced
this pull request
Oct 14, 2019
…perator-framework#2031) * pkg/ansible/controller/reconcile.go: fix invalid logger.Info usage * CHANGELOG.md: add line for operator-framework#2031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR fixes invalid usages of
logger.Infoinpkg/ansible/controller/reconcile.gothat cause a panic due to an invalid number of arguments passed to the function.logger.Inforequires an odd number of arguments, consisting of a mandatory message and an optional list ofkey1, value1, key2, value2, ..., keyN, valueNpairs.Motivation for the change:
See #2025
Closes #2025