Add support for running the operator out of cluster #218
Merged
fanminshi merged 1 commit intooperator-framework:masterfrom May 2, 2018
Merged
Add support for running the operator out of cluster #218fanminshi merged 1 commit intooperator-framework:masterfrom
fanminshi merged 1 commit intooperator-framework:masterfrom
Conversation
Contributor
|
We definitely like to have a better local testing/development workflow, see #142. However, I think we should wrap the local testing/running of the operator into a CLI command such as |
fanminshi
reviewed
May 2, 2018
| $ cd app-operator | ||
|
|
||
| # Test the app-operator locally by setting KUBERNETES_CONFIG | ||
| $ KUBERNETES_CONFIG=~/.kube/config go run cmd/app-operator/main.go |
Contributor
There was a problem hiding this comment.
Let's not add this KUBERNETES_CONFIG=~/.kube/config go run cmd/app-operator/main.go to the readme yet.
I want to wrap the above in a new operator-sdk up command. I will add that in a separate pr.
Contributor
|
Also follow the commit style here for your commits messages. |
Contributor
Author
|
👍 |
Contributor
|
@andersjanmyr Could you update the pr with my suggestion? or I can do it for you in this #220. |
Allows testing the operator without dockerizing it and deploying it to a cluster.
andersjanmyr
force-pushed
the
add_out_of_cluster_support
branch
from
8c09012 to
9803200
Compare
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to be able to test locally before I deploy to the cluster. This PR allows this through an environment variable.