Use k8s_info module instead of deprecated k8s_facts in molecule scaffold (#2168)#2203
Use k8s_info module instead of deprecated k8s_facts in molecule scaffold (#2168)#2203camilamacedo86 merged 3 commits intooperator-framework:masterfrom geerlingguy:2168-k8s_facts
Conversation
openshift-ci-robot
added
the
size/S
|
Do you mind making sure that the various Dockerfiles (in |
|
@fabianvf - ah, completely forgot about that. Bumped minimum to 2.9 instead of 2.8, and I think I covered the only three places that's required. |
|
/lgtm |
|
@geerlingguy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm /approved
Thank you for your contribution 🥇
|
|
||
| ### Changed | ||
| - Upgrade minimal Ansible version in the init projects from `2.4` to `2.6`. ([#2107](https://github.com/operator-framework/operator-sdk/pull/2107)) | ||
| - Use `k8s_info` module instead of deprecated `k8s_facts` module in molecule test scaffold. ([#2168](https://github.com/operator-framework/operator-sdk/issues/2168)) |
There was a problem hiding this comment.
Just a nit after the is OK to be merged 👍
| - Use `k8s_info` module instead of deprecated `k8s_facts` module in molecule test scaffold. ([#2168](https://github.com/operator-framework/operator-sdk/issues/2168)) | |
| - Replace in the ansible based operators module tests the `k8s_facts` for `k8s_info` which is deprecated. ([#2168](https://github.com/operator-framework/operator-sdk/issues/2168)) | |
| - Upgrade the ansible version from `2.8` to `2.9` on the ansible based operators image. ([#2168](https://github.com/operator-framework/operator-sdk/issues/2168)) |
|
@camilamacedo86 - Made those changes, thanks for pointing out the missing Changelog entry too! |
|
New changes are detected. LGTM label has been removed. |
|
Rebased due to CHANGELOG conflicts, as well as some conflicts due to adding |
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Need fix issue caused by rebasing with master.
|
@camilamacedo86 - Yikes, don't know how that made it through! I have fixed it, sorry about that. |
4 participants
Description of the change:
Replaces uses of the deprecated
k8s_factsmodule withk8s_info, which is the standard module for k8s information lookups in Ansible 2.9+.Motivation for the change:
Closes #2168