internal/olm/operator: OLM operator manager#2320
Merged
estroz merged 3 commits intooperator-framework:masterfrom Jan 10, 2020
Merged
internal/olm/operator: OLM operator manager#2320estroz merged 3 commits intooperator-framework:masterfrom
estroz merged 3 commits intooperator-framework:masterfrom
Conversation
estroz
added
kind/feature
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
estroz
force-pushed
the
feature/olm-poc-manager
branch
from
abe7b8d to
4bbe336
Compare
registry Deployment from a ConfigMap and serve that bundle from an operator-registry server to OLM test/integration,hack/tests/integration.sh: integration tests for internal/olm/operator Makefile,.travis.yml: run integration tests go.mod,go.sum,test/test-framework/go.sum: revendor
estroz
force-pushed
the
feature/olm-poc-manager
branch
from
5933c49 to
3fda432
Compare
added 2 commits
January 10, 2020 09:47
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
theishshah
approved these changes
Jan 10, 2020
Contributor
theishshah
left a comment
theishshah
left a comment
There was a problem hiding this comment.
Looks good, let's wait for a Travis success
joelanford
approved these changes
Jan 10, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
Ran the integration tests, looked over the logs, etc. Looks great!
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: Implement operator up/down logic using a registry-server and OLM in-cluster. See #1912 for discussion.
Motivation for the change: Users should be able to deploy an operator using OLM via
operator-sdk olm up, and remove an operator viaoperator-sdk olm down. See #1912 for more details.Note: integration tests exist for a simple memcached-operator. The CLI has not been hooked up yet though. This will be done in a follow-up.
Follow-up from #2313, broken out from #1912.